View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0021694 | mantisbt | ui | public | 2016-09-16 18:01 | 2021-02-21 11:56 |
Reporter | cproensa | Assigned To | syncguru | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | assigned | Resolution | open | ||
Product Version | 2.0.0-beta.2 | ||||
Target Version | 2.26.0 | ||||
Summary | 0021694: inconsistent presentation of required fields | ||||
Description | The mark for required fields is styled inconsistently on several forms "my account" form, the "" is separated from text The underlying issue is that now the "required" symbol has to be written explicitly in the HTML. In version 1.3 this was inserted by css :before | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
related to | 0023213 | new | Required standard fields are not marked as required when updating issues | |
related to | 0021807 | closed | community | The required fields are not explicitly visible when updating, resolving or closing an issue |
related to | 0022310 | closed | community | Use HTML5 "required" attribute for required form fields |
this is also the case in v2.0.0-beta.3 |
|
This is the css that was used in v1.3
should we apply something like that, instead of explicitly printing the |
|
IMO, yes, that would be much better EDIT: maybe consider using a margin-right for the spacing instead of hardcoded space (and we should make sure it works with RTL as well) |
|
@dregad @cproensa
This approach allows to implement also language dependant display (Assuming that Another thing to consider would be Translatewiki. [Edit 1] And while we are on it, we should also consider HTML5 client side validation, https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_input_required https://github.com/mantisbt/mantisbt/pull/1026 [Edit 2] The HTML5 |
|
@atrol This CSS was used to display the "legend" for the asterisk marking mandatory fields, at the form's bottom in Mantis 1.3. As far as I can tell, it is no longer used in 2.0 ( Note: an alternative to the dynamic stylesheet could be to use a jQuery AJAX to get the language string, which would probably be easier than maintaining many language-specific static CSS files. Re: client side validation, required only checks that the field is effectively not empty; a single space bypasses that. But anyway using this attribute makes perfect sense. |
|
Ideally, with PR 1026, required inputs would be identified by it's "required" property. If we still want to add a "*" to labels, we could base the display of that on the related input's property. However, if having a |
|
Right, didn't find any usage, opened 0023310 to remove it. |
|