View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0022171 | mantisbt | plug-ins | public | 2017-01-11 17:35 | 2017-01-31 04:02 |
Reporter | cproensa | Assigned To | dregad | ||
Priority | urgent | Severity | block | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 2.0.0 | ||||
Target Version | 2.1.0 | Fixed in Version | 2.1.0 | ||
Summary | 0022171: Redefine plugin version requirements | ||||
Description | With the new version scheme of major.minor.patch, | ||||
Tags | No tags attached. | ||||
You mean changing the logic in plugin API ? |
|
I assume @cproensa does not want to change the logic but means just replacing the dependency to something like |
|
Actually, i mean changing the logic in plugin api
I haven't tested, but i suspect that would not work, if it would resolve to >=2.0 AND <2.1 OR >=2.9 AND <3.0 |
|
@cproensa You are correct, see https://github.com/mantisbt/mantisbt/blob/release-2.0.0/core/plugin_api.php#L558
I think it makes sense to change this as you propose. Of course this implies that we'd have to defer any plugin API breaking change to the next major version (which is how it should be IMO). |
|
Repeating comment posted in response to vboctor's question in https://github.com/mantisbt/mantisbt/pull/991#issuecomment-272107185
It is. The problem is that the plugin API silently adds a |
|
MantisBT: master cab8a96e 2017-01-15 05:48 Details Diff |
Add Plugin API tests covering plugin_dependency() An initial series of test to execute known scenarios, including the case from issue 0022171. |
Affected Issues 0022171 |
|
mod - tests/Mantis/AllTests.php | Diff File | ||
add - tests/Mantis/PluginTest.php | Diff File | ||
MantisBT: master 574dfa29 2017-01-15 13:33 Details Diff |
Fix MantisCore plugin dependencies In issue 0017360, we introduced setting a default maximum version for MantisCore to avoid compatibility issues by disabling plugins which have not been updated for a new Mantis release, with a break on every minor version (x.Y.z). With 2.0 and the decision to only introduce breaking changes on major versions (X.y.z), this code has to be changed. Fixes 0022171 |
Affected Issues 0017360, 0022171 |
|
mod - core/plugin_api.php | Diff File | ||
MantisBT: master 1d96c88c 2017-01-25 05:51 Committer: GitHub Details Diff |
Merge plugin requirements PR Prevents plugins getting disabled when bumping MANTIS_VERSION to 2.1.x. Fixes 0022171 Also contains the following changes and improvements: - Add PHPUnit tests for plugin_dependency() function - Refactor plugin_version_check() to use PHP's version_compare() function instead of custom code - Reset MANTIS_VERSION to 2.1.0-dev. - Revert MantisCore version requirements in bundled plugins - Fix PHP notice when specifying plugin authors as array, fixes 0022205 - align code with documentation - Improved plugin documentation in Developers guide, fixes 0022206 PR https://github.com/mantisbt/mantisbt/pull/995 |
Affected Issues 0022171, 0022205, 0022206 |
|
mod - core/constant_inc.php | Diff File | ||
mod - core/plugin_api.php | Diff File | ||
mod - docbook/Developers_Guide/en-US/Plugins_Building.xml | Diff File | ||
mod - docbook/Developers_Guide/en-US/Plugins_Building_Source.xml | Diff File | ||
mod - manage_plugin_page.php | Diff File | ||
mod - plugins/Gravatar/Gravatar.php | Diff File | ||
mod - plugins/MantisCoreFormatting/MantisCoreFormatting.php | Diff File | ||
mod - plugins/MantisGraph/MantisGraph.php | Diff File | ||
mod - plugins/XmlImportExport/XmlImportExport.php | Diff File | ||
mod - tests/Mantis/AllTests.php | Diff File | ||
add - tests/Mantis/PluginTest.php | Diff File |