View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0028015 | mantisbt | db schema | public | 2021-03-08 08:46 | 2023-02-12 05:00 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | major | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Target Version | 2.26.0 | Fixed in Version | 2.26.0 | ||
Summary | 0028015: Update ADOdb to 5.21.4 | ||||
Description | New ADOdb release https://github.com/ADOdb/ADOdb/blob/v5.21.4/docs/changelog.md This needs to be tested carefully, as there's been quite a lot of changes since 5.20.x, particularly on mssql and to a lesser extent pgsql drivers. | ||||
Additional Information | |||||
Tags | adodb, upstream | ||||
related to | 0026837 | closed | dregad | Update ADOdb to 5.20.20 |
parent of | 0028068 | resolved | dregad | Impossible to insert child records with ADOdb 5.21.0 on mssql |
parent of | 0028069 | resolved | dregad | PHP notices leading to unusable system with ADOdb 5.21.0 on pgsql |
parent of | 0026599 | new | Behavioural changes for BLOBs in ADOdb 5.21 | |
parent of | 0029511 | resolved | dregad | MSSQL blocking error during installation. |
related to | 0029485 | closed | dregad | Update ADOdb to 5.20.21 |
related to | 0032028 | confirmed | Update ADOdb to 5.22.5 | |
Not all the children of this issue are yet resolved or closed. |
Breaks PostgreSQL - there are many notices as shown below, which cause other, sometimes fatal errors down the line
The regression was introduced by https://github.com/ADOdb/ADOdb/pull/367 |
|
@dregad Did some Tests on 2.24.5 (with ADOdb 5.21) for mssqlnative (SQLServer 2016, driver 5.9.0) 1) All views are Ok.
3) Add Project Ok
5) Add Note to Issue
Might be more. I'll check, but I doubt this is just mssql. Anything special about mysql not running into this? BTW: 2.24.5 (with ADOdb 5.20.20) for mssqlnative (SQLServer 2016, driver 5.9.0), no problems so far. Martin EDIT (dregad): added markdown |
|
Thanks for testing and reporting these details @obmsch, I'll look into it.
I have not done much manual testing yet. I just let the phpunit tests run via CI [1] and focused on the PostgreSQL failure so it is quite possible there are issues with MySQL too, but keep in mind that the latter is usually more error-tolerant so it would not be the first time that something fails on MSSQL but works just fine on MySQL. |
|
@dregad Looks like the Id (Identity) of an INSERT is not set/retrieved. Have to check, what has changed in the driver. |
|
As thought, its a problem with the mssqlnative driver and its handling of the last inserted Id (Identity). EDIT (dregad) added link to upstream issue. |
|
Thanks Martin. As mentioned upstream [1]
|
|
ADOdb 5.21.4 was released 2022-01-22 According to 0029511:0066196, identified MSSQL issues should be solved. Status of PostgreSQL ones unknown at this stage |
|
MantisBT: dependabot/composer/adodb/adodb-php-5.21.4 0350943c 2022-01-23 05:28 dependabot[bot] Committer: dregad Details Diff |
Bump adodb/adodb-php from 5.20.21 to 5.21.4 Bumps [adodb/adodb-php](https://github.com/ADOdb/ADOdb) from 5.20.21 to 5.21.4. - [Release notes](https://github.com/ADOdb/ADOdb/releases) - [Changelog](https://github.com/ADOdb/ADOdb/blob/master/docs/changelog.md) - [Commits](https://github.com/ADOdb/ADOdb/compare/v5.20.21...v5.21.4) --- updated-dependencies: - dependency-name: adodb/adodb-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Fixes 0028015, PR https://github.com/mantisbt/mantisbt/pull/1790 |
Affected Issues 0028015 |
|
mod - composer.lock | Diff File |